Skip to content

Conversation

@Pouyanpi
Copy link
Collaborator

@Pouyanpi Pouyanpi commented May 5, 2025

Renamed remove_thinking_traces to remove_reasoning_traces across the codebase for consistency. Added a deprecated field remove_thinking_traces with a warning to ensure backward compatibility.

  • Updated documentation, tests, and configurations.
  • Added a model validator to handle deprecated field usage.
  • Issued deprecation warnings when remove_thinking_traces is used.

BREAKING CHANGE: Configurations using remove_thinking_traces must migrate to remove_reasoning_traces from 0.15.0.

…asoning_traces`

Renamed `remove_thinking_traces` to `remove_reasoning_traces` across the
codebase for consistency. Added a deprecated field
`remove_thinking_traces` with a warning to ensure backward compatibility.

- Updated documentation, tests, and configurations.
- Added a model validator to handle deprecated field usage.
- Issued deprecation warnings when `remove_thinking_traces` is used.

BREAKING CHANGE: Configurations using `remove_thinking_traces` must
migrate to `remove_reasoning_traces` from 0.15.0.
@Pouyanpi Pouyanpi added this to the v0.14.0 milestone May 5, 2025
@Pouyanpi Pouyanpi requested a review from trebedea May 5, 2025 13:23
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Documentation preview

https://nvidia.github.io/NeMo-Guardrails/review/pr-1176

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.24%. Comparing base (457cd48) to head (b7eb378).
Report is 42 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1176      +/-   ##
===========================================
+ Coverage    68.22%   68.24%   +0.01%     
===========================================
  Files          161      161              
  Lines        15930    15938       +8     
===========================================
+ Hits         10869    10877       +8     
  Misses        5061     5061              
Flag Coverage Δ
python 68.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
nemoguardrails/llm/taskmanager.py 88.82% <ø> (ø)
nemoguardrails/rails/llm/config.py 90.00% <100.00%> (+0.15%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pouyanpi Pouyanpi merged commit f1dfbd6 into develop May 5, 2025
30 checks passed
@Pouyanpi Pouyanpi deleted the refactor/deprecate-remove-thinking-traces branch May 5, 2025 17:01
Pouyanpi added a commit that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants